| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: COPY WITH CSV FORCE QUOTE * -- REVIEW |
| Date: | 2009-07-25 00:08:13 |
| Message-ID: | 4A6A4CED.3010803@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> I have reviewed this and made a small tweak in the docco. I'm just about
>> ready to commit this, but I'm still slightly worried that passing NULL
>> to denote all columns in this piece of grammar:
>>
>
>
>> | FORCE QUOTE '*'
>> {
>> $$ = makeDefElem("force_quote", NULL);
>> }
>>
>
>
>> might be less than robust - it just feels slightly hacky, so I'd
>> appreciate others' thoughts.
>>
>
> I agree, that's ugly. Why don't you use an A_Star node?
>
>
>
OK, Done and committed. Nice little addition.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | KaiGai Kohei | 2009-07-25 00:16:47 | Re: SE-PostgreSQL Specifications |
| Previous Message | Sam Mason | 2009-07-24 23:45:47 | Re: SE-PostgreSQL Specifications |