| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: COPY WITH CSV FORCE QUOTE * -- REVIEW |
| Date: | 2009-07-24 23:25:51 |
| Message-ID: | 4A6A42FF.1010501@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Josh Berkus wrote:
>
> Stuff someone else should do:
>
> a. review code
> b. review code format
>
> I am done with this review.
I have reviewed this and made a small tweak in the docco. I'm just about
ready to commit this, but I'm still slightly worried that passing NULL
to denote all columns in this piece of grammar:
| FORCE QUOTE '*'
{
$$ = makeDefElem("force_quote", NULL);
}
might be less than robust - it just feels slightly hacky, so I'd
appreciate others' thoughts. If nobody else is bothered I will commit
the patch.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-07-24 23:31:13 | Re: COPY WITH CSV FORCE QUOTE * -- REVIEW |
| Previous Message | Tom Lane | 2009-07-24 23:21:40 | Re: Non-blocking communication between a frontend and a backend (pqcomm) |