Re: ECPG support for string pseudo-type

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Meskes <meskes(at)postgresql(dot)org>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ECPG support for string pseudo-type
Date: 2009-07-13 14:18:47
Message-ID: 4A5B4247.6030002@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Meskes írta:
> On Sat, Jul 04, 2009 at 05:09:04PM +0200, Boszormenyi Zoltan wrote:
>
>> OK, let me retry. This version treats "string" as a non-reserved word,
>> and also discovers whether the PGC contains this construct below,
>> as in ecpg/tests/preproc/type.pgc:
>>
>> exec sql type string is char[11];
>> typedef char string[11];
>>
>
> I don't like this because it means a datatype can change its meaning in the
> middle of a source file. Your new datatype is only needed for Informix
> compatibility, so why not only defining it when running in compatibility mode?
> An Informix file will not have such a typedef because it wouldn't/shouldn't
> work there either.
>
> Also the new datatype needs some documentation.
>
> Michael
>

Okay, I modified it so in Informix mode ECPG refuses
redefining the "string" type. I will add documentation and
also port it to 8.5devel, get_typedef() has changed since 8.4RC2
and it errors out now if asking for a non-typedef'd type name.

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-07-13 14:18:49 Re: Index-only-scans, indexam API changes
Previous Message Robert Haas 2009-07-13 14:18:27 Re: Launching commitfest.postgresql.org