From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: Does EXEC_BACKEND mode still need to propagate setlocale settings? |
Date: | 2009-07-08 18:46:09 |
Message-ID: | 4A54E971.6060609@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> The recent bug report about CheckMyDatabase() failing to use
> pg_perm_setlocale() led me to look for other uses of setlocale() that
> might be wrong. I found two fishy calls in restore_backend_variables().
I just did the exact same thing but you beat me..
> I am thinking though that the correct fix is to delete them and get
> rid of the overhead of transmitting the postmaster's setlocale settings
> to child processes this way. A regular backend is going to do
> CheckMyDatabase momentarily, and in any case it seems to me that the
> postmaster hasn't bothered to change these values off the system defaults
> and so there is no need to do anything special to inherit its values.
Agreed. In EXEC_BACKEND case, main() sets them to the same system
defaults before restore_backend_variables() is called.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-07-08 18:51:13 | Re: Does EXEC_BACKEND mode still need to propagate setlocale settings? |
Previous Message | Alvaro Herrera | 2009-07-08 18:25:44 | Re: [HACKERS] commitfest.postgresql.org |