From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Time to add a Git .mailmap? |
Date: | 2024-11-03 19:36:28 |
Message-ID: | 4A514864-E673-4B96-9A8A-B4241B13AD1E@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 1 Nov 2024, at 13:53, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 01.11.24 12:53, Alvaro Herrera wrote:
>> On 2024-Oct-31, Daniel Gustafsson wrote:
>>> When looking at our Git tree for a recent conference presentation I happened to
>>> notice that we have recently gained duplicate names in the shortlog. Not sure
>>> if we care enough to fix that with a .mailmap, but if we do the attached diff
>>> makes sure that all commits are accounted for a single committer entry.
>> LGTM. I'd also add this line while at it:
>> Peter Eisentraut <peter(at)eisentraut(dot)org> <peter_e(at)gmx(dot)net>
>> This takes care of all the duplicate "identities" in the history AFAICT.
>
> I'm not sure if this is a good use of the mailmap feature. If someone commits under <peter(at)companyfoo(dot)com> for a while and then later as <peter(at)companybar(dot)com>, and the mailmap maps everything to the most recent one, that seems kind of misleading or unfair? The examples on the gitmailmap man page all indicate that this feature is to correct accidental variations or obvious mistakes, but not to unify everything to the extent that it alters the historical record.
I agree with this and propose to leave it at the originally proposed mailmap
contents.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2024-11-03 20:54:33 | Re: pgsql: Implement pg_wal_replay_wait() stored procedure |
Previous Message | Tom Lane | 2024-11-03 19:07:02 | Re: Repeat the condition check twice in function distribute_qual_to_rels |