| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #4879: bgwriter fails to fsync the file in recovery mode |
| Date: | 2009-06-26 06:36:58 |
| Message-ID: | 4A446C8A.5070907@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Tom Lane wrote:
> I observe that the substantial amount of care we have taken over
> XLogFlush's handling of bad-input-LSN scenarios has been completely
> destroyed by the UpdateMinRecoveryPoint patch, which will fail
> disastrously (leaving the database unstartable/unrecoverable) if a
> bogusly large LSN is encountered during recovery.
Note that we don't update minRecoveryPoint to the LSN from the data
page, but to the LSN of the last replayed WAL record. A warning similar
to that at the end of XLogFlush() would be a good idea though, if the
data page LSN is greater.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2009-06-26 09:28:45 | Re: BUG #4879: bgwriter fails to fsync the file in recovery mode |
| Previous Message | Heikki Linnakangas | 2009-06-26 06:22:04 | Re: BUG #4879: bgwriter fails to fsync the file in recovery mode |