| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Andrew Chernow <ac(at)esilo(dot)com> |
| Cc: | TAKATSUKA Haruka <harukat(at)sraoss(dot)co(dot)jp>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: GetTokenInformation() and FreeSid() at port/exec.c |
| Date: | 2009-06-24 12:45:54 |
| Message-ID: | 4A422002.9050606@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andrew Chernow wrote:
>
>>
>> How about something like this? I switched to using LocalAlloc() in all
>> places to be consistent, instead of mixing heap and local. (Though per
>> doc, LocalAlloc is actually a wrapper for HeapAlloc in win32).
>
> Our patches crossed. Although, in my patch I left the allocation scheme
> alone since I wasn't sure if someone wanted that way. I'd suggest
> malloc and free if your going to change it. The only time I use an MS
> allocater is when a win32 api function specifically states it must be used.
Attached is a mix of our two patches. How does that look to you?
--
Magnus Hagander
Self: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| win32mem.patch | text/x-diff | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Chernow | 2009-06-24 12:51:13 | Re: BUG #4876: author of MD5 says it's seriously broken - hash collision resistance problems |
| Previous Message | Heikki Linnakangas | 2009-06-24 12:25:15 | Re: psql: FATAL: the database system is in recovery mode |