Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Bruce Momjian <momjian(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.
Date: 2009-06-11 23:01:13
Message-ID: 4A318CB9.9020909@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>
>> Bruce Momjian wrote:
>>
>> + #
>> + # Structure/union pointers in function prototypes and definitions have an extra
>> + # space after the asterisk:
>> + #
>> + # void x(struct xxc * a);
>>
>>
>> I know we should not be driven by our tools, but is there a case for a
>> coding standard that requires use of a typedef name here?
>>
>
> We use things like struct timeval and struct tm ... I don't think we
> should be creating typedefs for those, so it would be good to find a
> more general solution.
>
>

Good point.

cheers

andrew

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2009-06-11 23:22:37 Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.
Previous Message Tom Lane 2009-06-11 22:59:05 Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2009-06-11 23:22:37 Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.
Previous Message Tom Lane 2009-06-11 22:59:05 Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.