Re: [PATCH] cleanup hashindex for pg_migrator hashindex compat mode (for 8.4)

Hi,

On 05/26/2009 01:39 PM, Peter Eisentraut wrote:
> On Monday 25 May 2009 20:58:59 Andres Freund wrote:
>> and executing
>> `git config --global diff.context.command "git-external-diff"`
> We already knew that you could do it with a wrapper. But that isn't the
> answer we were looking for, because it will basically mean that 98% of casual
> contributors will get it wrong, and it will probably not work very well on
> Windows.
It works on windows, linux, solaris (thats what I could get my hands on
without bothering). I tested it - it works on any non ancient version of
git. (Ancient in the sense, that git at that time didnt work properly on
win anyway).
And providing a 5-line wrapper download-ready surely makes it easier
than figuring it out how to write one out of some git manpages.

Also it allows at least those who prefer context diffs to use them
easily when using git - that are the ones which seem to prefer using
them most.

> The goal is to get git-diff to do it itself.
I do not disagree.

Andres