Re: New trigger option of pg_standby

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Guillaume Smet <guillaume(dot)smet(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New trigger option of pg_standby
Date: 2009-05-13 18:26:15
Message-ID: 4A0B10C7.2040309@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> I don't think we're going to get this to work reliably without extending
>> the interface between the backend and restore_command. We've discussed
>> many methods and there's always some nasty corner-case like that.
>
>> I think we should leave back-branches as is, and go with Simon's
>> suggestion to add new "recovery_end_command" that's run when the
>> recovery is finished. That's simpler and more reliable than any of the
>> other approaches we've discussed, and might become handy for other
>> purposes as well.
>
>> Does someone want to take a stab at writing a patch for that?
>
> Does this conclusion mean that changing pg_standby is no longer
> on the table for 8.4? It certainly smells more like a new feature
> than a bug fix.

This whole thing can be considered to be a new feature. It's working as
designed. But people seem to be surprised about the current behavior (me
included), and we don't currently provide the behavior that most people
actually want. I think we should fix it for 8.4.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2009-05-13 18:29:59 Re: Implementation of GROUPING SETS (T431: Extended grouping capabilities)
Previous Message Joshua D. Drake 2009-05-13 18:22:42 Re: New trigger option of pg_standby