| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, David Fetter <david(at)fetter(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: Keyword list sanity check |
| Date: | 2009-04-30 20:45:31 |
| Message-ID: | 49FA0DEB.8070805@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> On Thursday 30 April 2009 10:27:45 David Fetter wrote:
>
>> I'd also like to propose that "strict clean" be a minimum code quality
>> metric for any Perl code in our code base. A lot of what's in there
>> is just about impossible to maintain.
>>
>
> use strict and use warnings, I think, although with use warnings I have
> occasionally run into the trouble of some old versions not supporting it (only
> via perl -w).
>
>
Right. I think strict mode is probably sufficient for utility code like
this.
Also note that we maintain the usual postgres indentation standards in
the perl MSVC stuff, by using perltidy thus:
perltidy -b -bl -nsfs -naws -l=100 -ole=unix *.pl *.pm
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jaime Casanova | 2009-04-30 20:50:09 | Re: Creating a tablespace directory in recovery |
| Previous Message | Andy Lester | 2009-04-30 20:04:54 | Re: Keyword list sanity check |