| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | David Fetter <david(at)fetter(dot)org> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Keyword list sanity check |
| Date: | 2009-04-30 10:30:02 |
| Message-ID: | 49F97DAA.8060706@enterprisedb.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Fetter wrote:
> Please clean up this code at least to the point where it's
> strict-clean, which means putting "use strict;" right after the
> shebang line and not checking it in until it runs that way.
>
> I tried, but couldn't make heads or tails of the thing, given all the
> unused- and similarly-named variables, failure to indent, etc. I
> don't know how to put this gently, but if you checked in C code with
> quality like this, you'd have it bounced with derision.
Yep, I'm completely novice at perl. I've checked in Laurent's patch to
clean it up, which at least makes it strict-clean.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-04-30 11:41:12 | Re: Keyword list sanity check |
| Previous Message | Laurent Laborde | 2009-04-30 10:28:21 | Perl coding style in postgresql |