Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
Date: 2009-04-02 08:50:08
Message-ID: 49D47C40.5040300@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Tom Lane wrote:
>>> What makes more sense to me is to add a table to encnames.c that
>>> provides the gettext name of every encoding that we support.
>
>> Do you mean a separate table there, or should we add a new column to one
>> of the existing tables?
>
> Whichever seems to make more sense is fine with me. I just don't want
> add-an-encoding maintenance requirements spread across N different
> source files.

I was about to start looking at this when that other thread
(http://archives.postgresql.org//pgsql-hackers/2009-03/msg01270.php)
started about related issues on other platforms. Seems we should have a
"coordinated fix" for this, so I'm going to want and see what come sout
of that one. Unless I'm misunderstanding thigns and they're not related?

//Magnus

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Kpierno 2009-04-02 14:18:18 pglogparser - pglogparser: New Directory
Previous Message Tom Lane 2009-04-02 03:51:50 pgsql: Fix GUC's reports of assign_hook failure to always include the

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-04-02 11:50:18 Re: [GENERAL] string_to_array with empty input
Previous Message Magnus Hagander 2009-04-02 08:35:14 Re: Path separator