Re: Patch: Crash on linux-x64

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Crash on linux-x64
Date: 2009-03-11 10:15:48
Message-ID: 49B78F54.6040401@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Dave Page wrote:
> Couple of thoughts about the patch...
>
> We should use #ifdef __WXGTK__ not __LINUX__ as we also support *BSD
> and Solaris, *but*, although the bug only occurs on Linux,
ok
> Should we just use this search code on all platforms for consistency and future
> enhancement?
I think yes - that will make the behaviour consistent on all the platform.

In wxWidgets, It starts searching the node starts with the pressed
character from the selected node.
If no such node found, it start searching the similar node from the ROOT
node.

In our function (FindItem), we look for the children, grand-children and
siblings below the selected node as the search criteria.
> Don't worry about submitting a new patch - I'll hack up whats there
> based on what we decide.
:)

--
Thanks & Regards,
Ashesh Vashi

EnterpriseDB INDIA: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2009-03-11 10:17:31 Re: 1.10 beta 1
Previous Message Guillaume Lelarge 2009-03-11 09:58:57 Re: SVN Commit by dpage: r7607 - trunk/pgadmin3/pgadmin/ui