Re: Allow on/off as input texts for boolean.

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Allow on/off as input texts for boolean.
Date: 2009-03-09 14:35:05
Message-ID: 49B52919.2040108@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

ITAGAKI Takahiro wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>
>> ITAGAKI Takahiro wrote:
>>> Here is a patch to allow 'on' and 'off' as input texts for boolean.
>> Regarding your FIXME comment, I think parse_bool* should be in bool.c
>> and declared in builtins.h, which guc.c already includes.
>> (Conceptually, the valid format of a bool should be drived by the
>> boolean type, not the GUC system, I think.)
>
> Here is an updated patch to move parse_bool* into bool.c.
> I also added tests of on/off values to the regression test.

applied

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2009-03-09 14:55:46 Re: Updates of SE-PostgreSQL 8.4devel patches (r1704)
Previous Message Emanuel Calvo Franco 2009-03-09 14:20:08 Re: problem inserting in GIN index