Re: BUG #4680: Server crashed if using wrong (mismatch) conversion functions

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Denis Afonin <vadm(at)itkm(dot)ru>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4680: Server crashed if using wrong (mismatch) conversion functions
Date: 2009-02-27 16:18:27
Message-ID: 49A81253.60509@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> When the conversion function doesn't work, any attempt to send any text
>> to the client will fail.
>
> Ah, now I remember: we arranged to short-circuit translation of the
> error message when we were in this situation. But it will still get
> passed through the encoding converter (rather uselessly, if it's all
> ASCII). I wonder how ugly it would be to try to suppress encoding
> conversion as well?

The error message might contain user data, which might contain non-ASCII
characters. Or maybe not, but it seems like a shaky assumption to make.
Sending invalidly encoded data to the client is a bad idea; who knows
how the client will react.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2009-02-27 16:37:25 Re: BUG #4680: Server crashed if using wrong (mismatch) conversion functions
Previous Message Chris Browne 2009-02-27 16:07:47 Re: Support platform of PostgresSQL 8.1.9 under IBM AIX 5.3

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-02-27 16:37:25 Re: BUG #4680: Server crashed if using wrong (mismatch) conversion functions
Previous Message Alvaro Herrera 2009-02-27 16:10:15 Re: B-tree "finish incomplete split" bug