Re: PATCH: Update autovacuum (for TOAST-TABLE) to use reloptions, instead of a system catalog

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Update autovacuum (for TOAST-TABLE) to use reloptions, instead of a system catalog
Date: 2009-02-24 09:00:24
Message-ID: 49A3B728.1070800@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Please find the patch for (TOAST-TABLE) autovacuum settings.

Patch contains changes for:
* Moved the code related to fetching the (Toast-Table) AutoVaccum
settings from dlgTable to pgTable.
* Showing AV settings (also the Toast-Table AV settings, if present) in
the properties listview.
* pgTable::GetSql() will now show custom AV settings for toast tables.

Dave Page wrote:
> On Mon, Feb 23, 2009 at 2:01 PM, Ashesh Vashi
> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>> Hi All,
>>
>> Please find the patch for the "Update autovacuum (for TOAST-TABLE) to use
>> reloptions, instead of a system catalog.
>
> Thanks Ashesh - I've committed what's there as it works as is,
> however, the custom AV settings for toast tables are not reflected in
> the output from pgTable::GetSql(). Could you fix that please?
>
> We should also add the AV settings to the properties listview (in
> pgTable::ShowTreeDetail), like we do with variables on databases and
> roles. Can you also look at that please?
>
> Thanks!
>

--
Thanks & Regards,
Ashesh Vashi

EnterpriseDB INDIA: http://www.enterprisedb.com

Attachment Content-Type Size
AutoVacuum_properties_list.patch text/x-diff 30.3 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Quan Zongliang 2009-02-24 09:23:26 Import: empty string and expression
Previous Message Ashesh Vashi 2009-02-24 02:50:33 Re: PATCH: Update autovacuum (for TOAST-TABLE) to use reloptions, instead of a system catalog