Re: WIP: fix SET WITHOUT OIDS, add SET WITH OIDS

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Marko Kreen <markokr(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: fix SET WITHOUT OIDS, add SET WITH OIDS
Date: 2009-02-09 16:41:10
Message-ID: 49905CA6.1060208@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Heikki Linnakangas wrote:
>>> Andrew Dunstan wrote:
>>>> How about a pg_dump flag that simply suppresses OIDs from the data
>>>> and schema?
>>> pg_dump -s postgres | sed -e 's/SET default_with_oids = true;/-- &/'
>
>> No good for non-text dumps.
>
> Also it would fail badly if the dump had in fact been made with -o.

Don't do that then. We're not talking about filtering any old dump you
have lying around. We're talking about adding a new flag to pg_dump. If
you can run pg_dump with a new flag, surely you can run it without -o in
text mode and use sed just as well.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Kreen 2009-02-09 16:43:02 Re: WIP: fix SET WITHOUT OIDS, add SET WITH OIDS
Previous Message Kevin Grittner 2009-02-09 16:40:13 Re: add_path optimization