| From: | Maksim Milyutin <milyutinma(at)gmail(dot)com> | 
|---|---|
| To: | Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com> | 
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> | 
| Subject: | Re: Hint to set owner for tablespace directory | 
| Date: | 2018-08-31 10:41:35 | 
| Message-ID: | 498a6ff8-7036-bec9-7d09-f3e24cb65b96@gmail.com | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
On 08/31/2018 01:12 PM, Rafia Sabih wrote:
>
>
> On Fri, Aug 31, 2018 at 3:30 PM, Maksim Milyutin <milyutinma(at)gmail(dot)com 
> <mailto:milyutinma(at)gmail(dot)com>> wrote:
>
>     On 08/31/2018 11:55 AM, Rafia Sabih wrote:
>
>>
>>     Adding to that this patch needs a rebase. And, please don't
>>     forget to run 'git diff --check', as it has some white-space issues.
>
>  git apply /home/edb/Desktop/patches/others/owner_tbsp_hint.patch
>  /home/edb/Desktop/patches/others/owner_tbsp_hint.patch:9: trailing 
> whitespace.
>         {
> /home/edb/Desktop/patches/others/owner_tbsp_hint.patch:10: trailing 
> whitespace.
>             bool wrong_owner = (errno == EPERM);
This is hex+ASCII display (from *hexdump -C owner_tbsp_hint.patch* 
output) of code fragment above:
000001a0  0a 20 09 09 65 6c 73 65  0a 2b 09 09 7b 0a 2b 09  |. 
..else.+..{.+.|
000001b0  09 09 62 6f 6f 6c 20 77  72 6f 6e 67 5f 6f 77 6e |..bool 
wrong_own|
000001c0  65 72 20 3d 20 28 65 72  72 6e 6f 20 3d 3d 20 45 |er = (errno 
== E|
000001d0  50 45 52 4d 29 3b 0a 2b  0a 20 09 09 09 65 72 65 |PERM);.+. 
...ere|
Problem lines don't have trailing whitespaces, only line feed (0x0a) symbols
> This is what I got. Please correct me if I am missng anything. I am 
> using centos 7,  just an FYI.
My git version is 2.7.4.
-- 
Regards, Maksim Milyutin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kato, Sho | 2018-08-31 10:48:55 | RE: speeding up planning with partitions | 
| Previous Message | Dilip Kumar | 2018-08-31 10:24:06 | Re: Undo logs |