Re: Remove unused param rte in set_plain_rel_pathlist

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zhang Mingli <zmlpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove unused param rte in set_plain_rel_pathlist
Date: 2022-11-12 15:00:39
Message-ID: 49867.1668265239@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Zhang Mingli <zmlpostgres(at)gmail(dot)com> writes:
> Param RangeTblEntry *rte in function set_plain_rel_pathlist is not used at all.
> Add a path to remove it.

I'm disinclined to change that, as it'd make set_plain_rel_pathlist
different from its sibling functions, which do need the RTE.

In practice this has cost zero anyway, since set_plain_rel_pathlist
will surely get inlined into its sole caller.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2022-11-12 18:26:19 Re: Lack of PageSetLSN in heap_xlog_visible
Previous Message Ranier Vilela 2022-11-12 14:03:46 Re: Avoid overhead open-close indexes (catalog updates)