From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: Per database connection limit buglet |
Date: | 2009-01-30 17:26:23 |
Message-ID: | 4983383F.6010909@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> Dave Page wrote:
>>> It's possible to set a per-database connection limit of < -1, which seems bogus:
>
>> Yeah. That's simple to fix, but I'm having trouble wordsmithing the
>> error message. This is what I came up with:
>
> Why does it need to be anything except GUC's standard "invalid value"
> message? I really don't believe that this case is worth making
> translators deal with an additional string.
I guess. The message in guc.c seems a bit cumbersome, though, so I did
create a new message for it. It's now simply "invalid connection limit: %d".
The check was missing from per-user connection limits, fixed that too.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Jorge Flores | 2009-02-01 12:28:52 | Re: BUG #2958: ERROR: 53200: out of memory |
Previous Message | Tom Lane | 2009-01-30 15:18:28 | Re: pg_listener entries deleted under heavy NOTIFY load only on Windows |