From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Patch to add Windows 7 support |
Date: | 2009-01-28 11:19:46 |
Message-ID: | 49803F52.5010009@hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dave Page wrote:
>> I don't think it's enough that we need to care about it really. I'm
>> thinking we could perhaps even just never set that, and not bother with
>> the version check...
>
> That was how I originally coded it, but figured we might as well set
> it if we can - it's not like it's expensive to do.
>
>> But perhaps we should set it only when launching as a service, and not
>> when running from the commandline?
>
> We could. I'm not sure there's a great deal of need - most people will
> run as a service, and it won't make any difference for those that
> start the postmaster directly.
I have applied this updated patch. It simplifies the if branches a bit
(imho, that is), and also adds the switch to only make the change when
starting as a service.
//Magnus
Attachment | Content-Type | Size |
---|---|---|
windows7.diff | text/x-diff | 4.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2009-01-28 11:30:36 | Re: Index Scan cost expression |
Previous Message | Cédric Villemain | 2009-01-28 10:48:42 | Re: Commitfest infrastructure (was Re: 8.4 release planning) |