Re: [PATCH] EnableDisableTrigger Cleanup & Questions

Robert Haas wrote:
> On Wed, Jan 21, 2009 at 6:17 AM, Jonah H. Harris <jonah(dot)harris(at)gmail(dot)com> wrote:
>> On Thu, Nov 6, 2008 at 12:03 AM, Jonah H. Harris <jonah(dot)harris(at)gmail(dot)com>
>> wrote:
>>> As I wasn't sure whether anyone agrees with my distaste for
>>> repurposing tgenabled as mentioned above, I have attached is a patch
>>> which minimally corrects the function comment for EnableDisableTrigger
>>> where fires_when is concerned.
>> Was there a reason that this cleanup patch wasn't applied?
>
> 1. It was submitted after the deadline for CommitFest:November.

Well, it's just comment changes...

> 2. It sounded like you had given up:

That's the impression I had, until I just went and read the thread in
detail.

>> Oh well, it was just a thought.
>
> 3. Tom Lane objected to it.
>
> http://archives.postgresql.org/message-id/20096.1225984128@sss.pgh.pa.us

If I understood the discussion correctly, Tom objected to the more
drastic change of renaming the catalog column. But the patch Jonah
posted didn't do that, it only changed the comments, precisely because
he felt that others might not want the more drastic change,

(I haven't checked whether the comment changes are a good idea. But they
probably are..)

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com