Re: Amcheck verification of GiST and GIN

> On 21 Feb 2025, at 19:29, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>
> I see this patch didn't move since December :-( I still think these
> improvements would be useful, it certainly was very helpful when I was
> working on the GIN/GiST parallel builds (the GiST builds stalled, but I
> hope to push the GIN patches soon).
>
> So I'd like to get some of this in too. I'm not sure about the GiST
> bits, because I know very little about that AM (the parallel builds made
> me acutely aware of that).
>
> But I'd like to get the GIN parts in. We're at v34 already, and the
> recent changes were mostly cosmetic. Does anyone object to me polishing
> and pushing those parts?

Hi Tomas!

Committing verification for any index type would help immensely. Currently we have many separate areas of work that just depend on this common part. GiST and GIN have a code for verification, which is bound together by this patch set. If someone, e.g., wants to work on BRIN - they have to deal with all the patch set.
If we have any second index in amcheck, no matter GiST or GIN, - it's clear how to split the work on other AMs.

Kirill spend a lot of time ironing out various false positives from GIN check. Kirill, what is your opinion about GIN verification? Does it look complete? (in a sense that it will not trigger false alarm, certainly it cannot catch all the type of corruptions)

Thanks!

Best regards, Andrey Borodin.