Re: Fixes for compiler warnings

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: alanwli(at)gmail(dot)com, Gregory Stark <stark(at)enterprisedb(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fixes for compiler warnings
Date: 2009-01-19 12:01:14
Message-ID: 49746B8A.4020601@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Magnus, you wanna clean up the mess? And what patch does the "few more"
> comment refer back to?
>
> A workable solution that both silences the warning and preserves
> localizability is to follow a coding pattern like this:
>
> const char *mymsg = gettext_noop("Some text to be localized.");
>
> ...
>
> errmsg("%s", _(mymsg)) // not just errmsg(mymsg)

For a change like
http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.480&r2=1.481

Will it work to stick _(hintmsg) around it there?

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2009-01-19 12:54:19 Re: Hot Standby dev build (v8)
Previous Message Heikki Linnakangas 2009-01-19 12:00:35 Re: Hot Standby dev build (v8)