From: | Andrew Chernow <andrew(at)esilo(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | libpq WSACleanup is not needed |
Date: | 2009-01-15 22:17:30 |
Message-ID: | 496FB5FA.5070404@esilo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
WSACleanup is not really needed during a PQfinish. Its horribly slow if
the library ref count is 0 and it actually unloads the winsock
library, adds 225ms to PQfinish.
Solution:
A) Call WSAStartup once and never clean it up. When the app dies, so do
the ref counts and winsock is automatically unloaded.
B) Have a way of specifying the behavior, the way it is now or tell
libpq to not initialize wsa at all (kinda like ssl init callbacks).
Leave it up to the application.
I think the WSA startup/cleanup stuff is silly. If I dynamically link
with a DLL, I want it automatically loaded and cleaned up.
Worst case, your app makes lots of connections to different backends.
So, it is constantly doing PQconnectdb and PQfinish; only has a single
conn open at a time. This means its constantly loading and unloading
winsock.
Andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Chernow | 2009-01-15 22:18:26 | libpq WSACleanup is not needed |
Previous Message | Tom Lane | 2009-01-15 22:16:33 | Re: Autovacuum daemon terminated by signal 11 |