| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | sushant354(at)gmail(dot)com, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: text search patch status update? |
| Date: | 2009-01-08 07:38:00 |
| Message-ID: | 4965AD58.5020001@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian wrote:
> Sushant Sinha wrote:
>> The default headline generation function is complicated. It checks a lot
>> of cases to determine the best headline to be displayed. So Heikki's
>> examples just say that headline generation function may not be very
>> intuitive. However, his examples were not affected by the bug.
>>
>> Because of the bug, hlcover was not returning a cover when the query
>> item was the first lexeme in the text. And so the headline generation
>> function will return just MINWORDS rather than the actual headline as
>> per the logic.
>>
>> After the patch you will see the difference in the example:
>>
>> http://archives.postgresql.org/pgsql-hackers/2008-07/msg00785.php
>
> Ah, thank you for the clarification. I now realize Heikki was more
> saying the code can be improved rather than reporting a bug. Thanks.
No, it does still look wrong to me.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2009-01-08 09:20:55 | Re: Latest version of Hot Standby patch |
| Previous Message | KaiGai Kohei | 2009-01-08 06:41:08 | Re: New patch for Column-level privileges |