| From: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, pgsql-hackers(at)postgresql(dot)org, bruce(at)momjian(dot)us, tgl(at)sss(dot)pgh(dot)pa(dot)us, simon(at)2ndQuadrant(dot)com |
| Subject: | Re: Updates of SE-PostgreSQL 8.4devel patches (r1389) |
| Date: | 2009-01-08 02:55:08 |
| Message-ID: | 49656B0C.1060609@ak.jp.nec.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> KaiGai Kohei wrote:
>
>> Could you deliver "bool validate" to the validate_string_relopt callback?
>> In this specification, invoked callback cannot know whether it should
>> really raise an error for invalid reloption, or not.
>
> Hmm, would it be better to not call the validation callback at all if
> validate is not true?
In my preference, it is better to invoke the validation callback with
a validate flag, because it enables to give guest of subsystem a chance
to print notice without raising an error when the "value" is invalid
but "validate" is false.
However, both options are acceptable for me. It's your decision.
Thanks,
--
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2009-01-08 03:10:39 | Re: Meridiem markers (was: [BUGS] Incorrect "invalid AM/PM string" error from to_timestamp) |
| Previous Message | ITAGAKI Takahiro | 2009-01-08 02:54:36 | Re: Solve a problem of LC_TIME of windows. |