Re: HAVE_FSEEKO for WIN32

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HAVE_FSEEKO for WIN32
Date: 2009-01-07 13:52:10
Message-ID: 4964B38A.6050201@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander wrote:
> Bruce Momjian wrote:
>
>> Andrew Dunstan wrote:
>>
>>> Cleaning up the parallel restore patch I came across a question I might
>>> have asked before, but one which in any case I worked around:
>>>
>>> Why do we carefully define fseeko() for WIN32 but then not define
>>> HAVE_FSEEKO, which makes doing the former pretty much pointless?
>>>
>> With Andrew, I have developed and applied the attached patch so MinGW
>> handles fseeko() translation similar to Unix.
>>
>> Someone will need to update MSVC to have similar behavior.
>>
>
> Which is what? :-)
>
> It just needs to set HAVE_FSEEKO to 1 in pg_config.h?
>
>
>

Yep. I have fixed it already.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-01-07 13:54:58 Re: Updates of SE-PostgreSQL 8.4devel patches (r1389)
Previous Message Alvaro Herrera 2009-01-07 13:45:45 Re: Updates of SE-PostgreSQL 8.4devel patches (r1389)