Re: review: xml_is_well_formed

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mike Fowler <mike(at)mlfowler(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: review: xml_is_well_formed
Date: 2010-08-13 18:43:39
Message-ID: 4963.1281725019@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mike Fowler <mike(at)mlfowler(dot)com> writes:
> On 11/08/10 21:27, Tom Lane wrote:
>> Yes. Mike, are you expecting to submit a new version before the end of
>> the week?

> Yes and here it is, apologies for the delay. I have re-implemented
> xml_is_well_formed such that it is sensitive to the XMLOPTION. The
> additional _document and _content methods are now present. Tests and
> documentation adjusted to suit.

Applied with minor cleanups, mostly in the documentation. The only
thing that seems worth remarking on is that since xml_is_well_formed
now depends on a GUC variable, it *cannot* be marked IMMUTABLE. The
right marking in such cases is STABLE.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-08-13 19:15:21 Re: WIP partial replication patch
Previous Message Boszormenyi Zoltan 2010-08-13 18:31:17 WIP partial replication patch