Re: First-draft release notes for back branches are up

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: First-draft release notes for back branches are up
Date: 2019-05-04 15:15:24
Message-ID: 4958.1556982924@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> "Michael" == Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Michael> I have noticed a typo:
> Michael> Errors, such as lack of permissions to read the directory, were not
> Michael> detected or reported correctly; instead the code silently acted as
> Michael> - though the directory were empty.
> Michael> + though the directory was empty.

> "as though ... were ..." is correct English; it's a counterfactual
> clause so the subjunctive is appropriate here.

Thanks. It's been too long since high school English, so I was having
a hard time remembering the correct grammatical term for this; but
I'd just automatically written it that way and was pretty sure it
was right.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-05-04 15:39:04 Re: make maintainer-clean and config.cache
Previous Message Tom Lane 2019-05-04 15:04:07 Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6