Re: Kerberos patch in the queue

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Kerberos patch in the queue
Date: 2005-04-15 17:18:12
Message-ID: 4958.1113585492@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> I'd like to vote in favor of this patch:
> http://candle.pha.pa.us/mhonarc/patches2/msg00025.html.

> I know Tom said he didn't really like it, but I'd ask you to reconsider
> that.

The patch is unacceptable as is because (a) it adds a libpq
configuration parameter that acts differently from all the other ones
(not supported in connect strings for instance) and (b) it adds no
documentation for that variable, nor for the server-side variable it
adds. Doing the libpq parameter in a more thorough fashion is just a
matter of programming-by-example (grep for CONNECT_TIMEOUT for an
example) but I for one don't know enough about Kerberos to document
the thing.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2005-04-15 17:41:14 Re: Kerberos patch in the queue
Previous Message Alvaro Herrera 2005-04-15 17:08:50 Re: Why not cache stable functions?