From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Don't use OidIsValid to check the return value of |
Date: | 2008-12-20 16:11:30 |
Message-ID: | 494D1932.3000207@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Definitely a necessary fix, but you missed what I think is actually
> causing the crashes:
>
> if (PointerIsValid(DatumGetPointer(datum)))
> ! repl_val[Anum_pg_foreign_data_wrapper_fdwoptions - 1] = ObjectIdGetDatum(datum);
>
> should be
>
> if (PointerIsValid(DatumGetPointer(datum)))
> ! repl_val[Anum_pg_foreign_data_wrapper_fdwoptions - 1] = datum;
>
> ObjectIdGetDatum probably is zeroing the high-order half of the pointer
> datum.
Doh, how could I miss that, on the very next line :-)
> I committed this along with some other cosmetic fixes.
Thanks.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-12-20 16:17:52 | Re: [COMMITTERS] pgsql: Append major version number and for libraries soname major |
Previous Message | Andrew Dunstan | 2008-12-20 16:05:18 | Re: pgsql: Fix various confusions of pointers and OIDs, unsafe assumptions |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-12-20 16:17:52 | Re: [COMMITTERS] pgsql: Append major version number and for libraries soname major |
Previous Message | Tom Lane | 2008-12-20 15:58:15 | Re: [COMMITTERS] pgsql: SQL/MED catalog manipulation facilities This doesn't do any |