Re: [COMMITTERS] pgsql: SQL/MED catalog manipulation facilities This doesn't do any

Tom Lane wrote:
> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
>> Log Message:
>> -----------
>> SQL/MED catalog manipulation facilities
>
> The buildfarm says this patch has got serious portability issues.
>
> grebe, dugong, and ermine are all crashing here:
>
> --- 109,115 ----
> (3 rows)
>
> ALTER FOREIGN DATA WRAPPER foo OPTIONS (a '1', b '2');
> ! server closed the connection unexpectedly
> ! This probably means the server terminated abnormally
> ! before or while processing the request.
> ! connection to server was lost
>
> (Unfortunately I can't reproduce this on any of my own machines.)

Neither can I. All the non-Windows crashes in the buildfarm seem to be
on 64-bit machines, although not all 64-bit members crash.

The callers of transformGenericOptions-function in foreigncmds.c use
OidIsValid to check the return value of transformGenericOptions, but it
returns an array, not an Oid. I committed a fix for that, we'll see if
it heals the buildfarm.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com