Re: SQL/MED compatible connection manager

From: Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SQL/MED compatible connection manager
Date: 2008-12-15 19:55:13
Message-ID: 4946B621.5060504@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut wrote:
> Now the way I read the FDWs you provide (default and pgsql), you are
> creating your own API for initialization and options validation that is
> not in the standard. That would appear to contradict the idea of a
> standard interface.

This is now fixed -- the option validation and connection lookup functions
have been made optional. InitializeFDW and _PG_fini have been dropped,
functions are looked up in GetForeignDataWrapperLibrary(). I decided not to
worry too much about the function pointers getting stale due to library
changes and reloads, as that requires some deliberate actions as a superuser.

I also added _pg prefixes to the non-standard functions so that these are not
confused with the standard FDW functions.

psql describe commands to \dew, \des and \deu as discussed in
http://archives.postgresql.org/pgsql-hackers/2008-12/msg00888.php

PS. Would it be more convenient to use the ~user area at git.postgresql.org
for review? I haven't requested a user account yet, but will do so if it
simplifies the review. The patches would still be posted to list as well.

regards,
Martin

Attachment Content-Type Size
connection-manager-1215.patch.gz application/x-gzip 54.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2008-12-15 20:14:02 Re: planner issue with constraint exclusion
Previous Message Tom Lane 2008-12-15 19:50:50 Re: Mostly Harmless: Welcoming our C++ friends