From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl. |
Date: | 2021-10-08 15:41:50 |
Message-ID: | 4941f5a5-2d50-1a0e-6701-14c5fefe92d6@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 10/1/21 6:34 PM, Andres Freund wrote:
> Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
>
> The previous approach didn't really work on windows, due to the PATH separator
> being ';' not ':'. Instead of making the PATH change more complicated,
> reference the binary using the TESTDIR environment.
>
> Reported-By: Andres Freund <andres(at)anarazel(dot)de>
> Suggested-By: Andrew Dunstan <andrew(at)dunslane(dot)net>
> Discussion: https://postgr.es/m/20210930214040.odkdd42vknvzifm6@alap3.anarazel.de
> Backpatch: 14-, where the test was introduced.
>
I don't think any of us were thinking very clearly about this. Of
course, MSVC doesn't build executables in $TESTDIR. If we want to pick
up the executable from where it's built we'll need a little help from
vcregress.pl. I haven't tested it but What I have in mind is something
like the attached.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
libpg_pipeline_fix.patch | text/x-patch | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-10-08 16:03:41 | Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. |
Previous Message | Daniel Gustafsson | 2021-10-08 08:03:42 | Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. |