| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: visibility maps |
| Date: | 2008-12-06 17:32:05 |
| Message-ID: | 493AB715.505@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pavan Deolasee wrote:
> /*
> * Size of the bitmap on each visibility map page, in bytes. There's no
> * extra headers, so the whole page minus except for the standard page
> header
> * is used for the bitmap.
> */
> #define MAPSIZE (BLCKSZ - SizeOfPageHeaderData)
>
>
> ISTM that we should MAXALIGN the SizeOfPageHeaderData to compute MAPSIZE.
> PageGetContents() works that way and I believe that's the right thing to do.
Yep, you're right. Thanks, fixed.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Martin Pihlak | 2008-12-06 17:34:49 | Re: SQL/MED compatible connection manager |
| Previous Message | Heikki Linnakangas | 2008-12-06 17:04:59 | Re: visibility maps |