| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Russell Smith <mr-russ(at)pws(dot)com(dot)au>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PoolSnoopy <tlatzelsberger(at)gmx(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved. |
| Date: | 2008-12-03 13:56:14 |
| Message-ID: | 49368FFE.7000401@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Bruce Momjian wrote:
> Bruce Momjian wrote:
>> Thanks for the review, Magnus. I have adjusted the patch to use the
>> same mutex every time the counter is accessed, and adjusted the
>> pqsecure_destroy() call to properly decrement in the right place.
>>
>> Also, I renamed the libpq global destroy function to be clearer
>> (the function is not exported).
>
> Here is an updated version of the patch to match CVS HEAD.
I've updated it to match what's CVS HEAD now, and made some minor
modifications. Renamed destroySSL() to make it consistent with
initializeSSL(). Added and changed some comments. ssldiff.patch contains
my changes against Bruce's patch.
I also removed the #ifdef NOT_USED parts. They are in CVS history if we
need them, and they're trivial things anyway, so I think this is much
cleaner.
With this, it looks fine to me. Especially since we've seen some testing
from the PHP folks already.
//Magnus
| Attachment | Content-Type | Size |
|---|---|---|
| ssl.patch | text/x-diff | 9.4 KB |
| ssldiff.patch | text/x-diff | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-12-03 20:05:54 | Re: Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved. |
| Previous Message | Alvaro Herrera | 2008-12-02 17:31:17 | Re: BUG #4560: bug 4528 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gregory Stark | 2008-12-03 13:58:05 | Re: Visibility map, partial vacuums |
| Previous Message | Alvaro Herrera | 2008-12-03 13:51:20 | Re: Visibility map, partial vacuums |