Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new
Date: 2008-11-29 13:43:23
Message-ID: 493146FB.7040300@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Tom Lane wrote:
>>> * This seems to be still mostly NetBSD code, so I think you need to do
>>> more than just credit them in an aside. Should we repeat the full
>>> NetBSD copyright notice for this one function?
>
>> Do you mean the
>> * Copyright (c) 1989, 1993, 1994
>> * The Regents of the University of California. All rights reserved.
>> *
>> * This code is derived from software contributed to Berkeley by
>> * Guido van Rossum.
>
>> part, or the whole licence? Since the licence is the same as ours, doing
>> that seems like overkill.
>
> Well, it does say
>
> * 1. Redistributions of source code must retain the above copyright
> * notice, this list of conditions and the following disclaimer.
>

Right, maybe we'd better do that even if it's identical to our own.
Better credit too much than not enough. I'll put the whole thing in -
will move the function to the bottom of the file as well to clearly
isolate which parts it's referring to.

//Magnus

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2008-11-29 13:49:35 Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new
Previous Message Tom Lane 2008-11-29 00:39:46 pgsql: Fix recently-added array_agg tests to ensure they produce stable

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2008-11-29 13:49:35 Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new
Previous Message Andrew Gierth 2008-11-29 03:07:49 BUG #4553: HOLD cursors not materializing results fully