Re: Brittleness in regression test setup

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Brittleness in regression test setup
Date: 2008-11-26 12:03:21
Message-ID: 492D3B09.3020604@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera wrote:
> Is it possible to make it retry in case the chosen port is busy? I
> guess a simple check should suffice, ignoring the obvious race condition
> that someone uses the port after you checked it was OK.

Well, the whole point of this exercise was to avoid that. If we had a
way to do a "simple check", we might as well stick to the hardcoded port
and count up from that or something.

The problem with doing the checking is that you have to emulate the
complete postmaster logic for port numbers, listen addresses, Unix
domain socket directories, etc. That can become quite involved.

Then again, a simple way to avoid the issue altogether on platforms
supporting Unix-domain sockets would be to run the test over Unix-domain
sockets (which we do anyway) placed in a private directory. How about that?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2008-11-26 12:04:36 Re: Brittleness in regression test setup
Previous Message Peter Eisentraut 2008-11-26 11:56:35 Re: Brittleness in regression test setup