Re: Autoconf, libpq and replacement function

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Autoconf, libpq and replacement function
Date: 2008-11-21 13:36:07
Message-ID: 4926B947.3030700@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> AFAICS, we're not doing this for any other functions though - or am I
>> too tired and just looking in the wrong place? Or is that because
>> they're just function definitions and not #defines?
>> (I want to be sure to stick whatever new file there is in the same place..)
>
> src/include/rusagestub.h is doing things more or less this way.
>
> Also, right now we have got
>
> src/include/getaddrinfo.h
> src/include/getopt_long.h
>
> which really make me itch now that I am contemplating the possibility
> that we try to use libc-supplied code for these functions along with
> our own header definitions.
>
> I think the reason we've avoided putting such stuff into include/port/
> is that right now that directory consists exclusively of OS-specific
> files. Maybe we need another include subdirectory?

Or in the same directly, called something else. Like fnmatchstub.h. See
attached, seems reasonable?

//Magnus

Attachment Content-Type Size
wildcard_cert.diff text/x-diff 15.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-11-21 14:13:14 Re: SSL configure patch: review
Previous Message Simon Riggs 2008-11-21 13:35:35 Re: Review: Hot standby