| From: | KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Updates of SE-PostgreSQL 8.4devel patches (r1197) |
| Date: | 2008-11-18 16:42:38 |
| Message-ID: | 4922F07E.1050208@kaigai.gr.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> writes:
>> I'll try your approash in first, as follows:
>
> This seems a vast amount of uglification to avoid adding an argument to
> CreateTemplateTupleDesc. We do that kind of thing all the time --- it
> is a simple and reliable change to make.
>
> When designing a patch, you should generally try to make the code look
> like the patch has been there all along. Contorting logic to avoid
> a simple API change is not good.
Hmm..., I think your opinion is right, indeed.
In my conclusion, I want to postpone the feature to toggle row-level
access controls due to its scale of changes.
I can understand the requirements for reduction of storage consumption
with security attribute. I'll implement it next to the main feature of
SE-PostgreSQL.
Simon,
I'm sorry, if my expression felt you uncomfortable.
Thanks,
--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2008-11-18 17:07:31 | Re: Updated posix fadvise patch v19 |
| Previous Message | Gregory Stark | 2008-11-18 16:30:22 | Re: Updated posix fadvise patch v19 |