| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: The suppress_redundant_updates_trigger() works incorrectly |
| Date: | 2008-11-06 02:03:31 |
| Message-ID: | 49125073.5080800@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
KaiGai Kohei wrote:
> *** 80,88 ****
> HeapTupleHeaderGetNatts(oldheader)) &&
> ((newheader->t_infomask & ~HEAP_XACT_MASK) ==
> (oldheader->t_infomask & ~HEAP_XACT_MASK)) &&
> ! memcmp(((char *)newheader) + offsetof(HeapTupleHeaderData, t_bits),
> ! ((char *)oldheader) + offsetof(HeapTupleHeaderData, t_bits),
> ! newtuple->t_len - offsetof(HeapTupleHeaderData, t_bits)) == 0)
> {
> /* ... then suppress the update */
> rettuple = NULL;
> --- 86,94 ----
> HeapTupleHeaderGetNatts(oldheader)) &&
> ((newheader->t_infomask & ~HEAP_XACT_MASK) ==
> (oldheader->t_infomask & ~HEAP_XACT_MASK)) &&
> ! memcmp(((char *)newheader) + newheader->t_hoff,
> ! ((char *)oldheader) + oldheader->t_hoff,
> ! newtuple->t_len - newheader->t_hoff) == 0)
> {
> /* ... then suppress the update */
> rettuple = NULL;
>
Wouldn't this omit comparing the null bitmap?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2008-11-06 02:17:54 | Re: plperl needs upgrade for Fedora 10 |
| Previous Message | KaiGai Kohei | 2008-11-06 01:47:04 | Re: The suppress_redundant_updates_trigger() works incorrectly |