| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Toast bug in CVS HEAD |
| Date: | 2008-11-05 20:46:50 |
| Message-ID: | 4912063A.7060803@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> It's kind of annoying to introduce a search when it's so seldom needed,
> though. How about something like
>
> /* fast path for common case */
> if (key[i].sk_attno == irel->rd_index->indkey.values[i])
> key[i].sk_attno = i + 1;
> else
> ... search as you have it ...
I doubt it's worth it, given that there's only a couple of columns in
the index and in the scan key anyway.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2008-11-05 21:05:53 | Re: [WIP] In-place upgrade |
| Previous Message | Heikki Linnakangas | 2008-11-05 20:45:24 | Re: A bug with ALTER TABLE SET WITHOUT OIDS in CVS HEAD |