| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and |
| Date: | 2008-11-01 13:18:36 |
| Message-ID: | 490C572C.2070304@enterprisedb.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Simon Riggs wrote:
> On Fri, 2008-10-31 at 15:05 +0000, Heikki Linnakangas wrote:
>> Log Message:
>> -----------
>> Unite ReadBufferWithFork, ReadBufferWithStrategy, and ZeroOrReadBuffer
>> functions into one ReadBufferExtended function, that takes the strategy
>> and mode as argument. There's three modes, RBM_NORMAL which is the default
>> used by plain ReadBuffer(), RBM_ZERO, which replaces ZeroOrReadBuffer, and
>> a new mode RBM_ZERO_ON_ERROR, which allows callers to read corrupt pages
>> without throwing an error. The FSM needs the new mode to recover from
>> corrupt pages, which could happend if we crash after extending an FSM file,
>> and the new page is "torn".
>
> I thought you were adding the "read buffer only if in cache" option
> also?
No, but if it's needed, it should now fit well into the infrastructure,
as a new ReadBuffer mode.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-11-01 15:01:20 | Re: [COMMITTERS] pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and |
| Previous Message | Michael Meskes | 2008-11-01 12:42:15 | pgsql: Use string component in index structure. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-11-01 15:01:20 | Re: [COMMITTERS] pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and |
| Previous Message | Hannu Krosing | 2008-11-01 12:52:06 | Re: Enable pl/python to return records based on multiple OUT params |