Re: minimal update

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Kenneth Marshall <ktm(at)rice(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, David Fetter <david(at)fetter(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minimal update
Date: 2008-10-29 19:34:35
Message-ID: 4908BACB.7040205@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
>
> Kenneth Marshall wrote:
>> On Wed, Oct 22, 2008 at 06:05:26PM -0400, Tom Lane wrote:
>>
>>> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>>>
>>>>> On Wed, Oct 22, 2008 at 3:24 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>>>
>>>>>> "Minimal" really fails to convey the point here IMHO. How about
>>>>>> something like "suppress_no_op_updates_trigger"?
>>>>>>
>>>> I think it means something to us, but "no op" is a very technical
>>>> phrase
>>>> that probably doesn't travel very well.
>>>>
>>> Agreed --- I was hoping someone could improve on that part. The only
>>> other words I could come up with were "empty" and "useless", neither of
>>> which seem quite le mot juste ...
>>>
>>> regards, tom lane
>>>
>>>
>> redundant?
>>
>>
>>
>
> I think I like this best of all the suggestions -
> suppress_redundant_updates_trigger() is what I have now.
>
> If there's no further discussion, I'll go ahead and commit this in a day
> or two.

Nitpicking, but you have:
+ <para>
+ Currently <productname>PostgreSQL</> provides one built in trigger
+ function, <function>suppress_redundant_updates_trigger</>,

Should we perhaps mention the fulltext triggers (with the appropriate
links) here? If it's intended to be an authoritative list of the
"userspace" triggers we ship, I think that may be a good idea.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2008-10-29 19:35:21 Re: minimal update
Previous Message Alvaro Herrera 2008-10-29 19:32:18 Re: autovacuum: I need some explanation