From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Any reason to have heap_(de)formtuple? |
Date: | 2008-10-23 15:11:39 |
Message-ID: | 4900942B.5080008@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane napsal(a):
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
>> Currently in heaptuple.c we have duplicated code. heap_deformtuple and
>> heap_formtuple are mark as a obsolete interface. Is any reason to have still
>> them? I know that they are still used on many places, but is there any stopper
>> to keep these function alive?
>
> Well, aside from the gruntwork needed to convert all the core code that
> still uses the old APIs, there's the prospect of breaking extension
> modules that still use the old APIs. It's kind of annoying to have two
> copies of that code, but less annoying than removing it would be ...
>
What's about convert null array to boolean and call heap_form_tuple?
Zdenek
--
Zdenek Kotala Sun Microsystems
Prague, Czech Republic http://sun.com/postgresql
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-10-23 15:14:06 | Re: Any reason to have heap_(de)formtuple? |
Previous Message | Tom Lane | 2008-10-23 15:11:33 | Re: Unicode escapes in literals |