Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

Another advantage of triggers over rules is that it would work with COPY
which is probably a desired feature.

Emmanuel

Jaime Casanova wrote:
> just remembering that -patches is a dead list, so i'm sending this to
> -hackers where it will have more visibility...
>
> ---------- Forwarded message ----------
> From: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
> Date: Oct 22, 2008 9:43 AM
> Subject: Re: [PATCHES] Auto Partitioning Patch - WIP version 1
> To: Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com>
> Cc: Bruce Momjian <bruce(at)momjian(dot)us>, NikhilS <nikkhils(at)gmail(dot)com>,
> Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-patches(at)postgresql(dot)org
>
>
> On 10/22/08, Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>>
>>>>> Thanks for taking a look. But if I am not mistaken Gavin and co. are
>>>>>
>> working
>>
>>>>> on a much exhaustive proposal. In light of that maybe this patch might
>>>>>
>> not
>>
>>>>> be needed in the first place?
>>>>>
>>>>> I will wait for discussion and a subsequent collective consensus here,
>>>>> before deciding the further course of actions.
>>>>>
>>>> I think it is unwise to wait on Gavin for a more complex implemention
>>>> --- we might end up with nothing for 8.4. As long as your syntax is
>>>> compatible with whatever Gavin proposed Gavin can add on to your patch
>>>> once it is applied.
>>>>
>>>>
>>> seems like you're a prophet... or i miss something?
>>>
>>>
>> :)
>>
>> Maybe I will try to summarize the functionality of this patch, rebase it
>> against latest CVS head and try to get it on the commitfest queue atleast
>> for further feedback to keep the ball rolling on auto-partitioning...
>>
>>
>
> yeah! i was thinking on doing that but still have no time... and
> frankly you're the best man for the job ;)
>
> one thing i was thinking of is to use triggers instead of rules just
> as our current docs recommends
> http://www.postgresql.org/docs/8.3/static/ddl-partitioning.html
>
> with the benefit that a trigger can check if the child table exists
> for the range being inserted and if not it can create it first...
> haven't looked at the code in the detail but seems that your patch is
> still missing the "create rule" part so we are in time to change
> that... no?
>

--
Emmanuel Cecchet
FTO @ Frog Thinker
Open Source Development & Consulting
--
Web: http://www.frogthinker.org
email: manu(at)frogthinker(dot)org
Skype: emmanuel_cecchet