| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Weird behaviour with ALTER TABLE ... SET TABLESPACE ... statement |
| Date: | 2008-10-06 19:24:07 |
| Message-ID: | 48EA65D7.8020507@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> Yeah, seems like we need to allocate a new relfilenode in the new
>> tablespace.
>
> I looked into tablecmds.c and verified that ATExecSetTableSpace doesn't
> worry about selecting a new relfilenode. I'm also noticing a number of
> permissions-type checks that seem like they'd better be done in
> ATPrepSetTableSpace, because we don't go through ATExecSetTableSpace
> if the table requires rewriting for other reasons. All in all this
> code seems to need more careful review than it's gotten so far.
> You want to do it?
I'll give it a shot.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Grzegorz Jaskiewicz | 2008-10-06 19:59:47 | query path, and rules |
| Previous Message | Greg Smith | 2008-10-06 17:02:39 | Re: Shouldn't pg_settings.enumvals be array of text? |