Re: Re: [COMMITTERS] pgsql: Allow pg_regress to be run outside the build tree.

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Allow pg_regress to be run outside the build tree.
Date: 2008-10-02 13:19:53
Message-ID: 48E4CA79.6050907@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> vpath build should be fixed now. MSVC will need to update the
>> pg_regress call sites, but I'll leave that to those maintaining that
>> build system. In particular, the --dlpath option needs to be added.
>
> contrib is still pretty broken. One part of it is needing a --srcdir
> option in pgxs.mk, which I fixed. But some of the modules still
> fail --- it looks like the problem is with the ones having data/
> subdirectories. You seem to have taken out the copying of the data
> files into the vpath build tree, but I think you might have to
> put it back.

I think the right fix would be to convert those .sql files to
input/*.source files and have pg_regress substitute the absolute
directory names in them, like it is done for the backend.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-10-02 13:28:24 Re: Re: [COMMITTERS] pgsql: Allow pg_regress to be run outside the build tree.
Previous Message Tom Lane 2008-10-02 12:27:47 Re: Re: [COMMITTERS] pgsql: Allow pg_regress to be run outside the build tree.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-10-02 13:28:24 Re: Re: [COMMITTERS] pgsql: Allow pg_regress to be run outside the build tree.
Previous Message Jonah H. Harris 2008-10-02 13:12:16 Re: Block-level CRC checks